Skip to content

Fix dip switches for Mahjong Crystal Gal #13734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

buffis
Copy link
Contributor

@buffis buffis commented May 23, 2025

Some fixes for dips for Mahjong Crystal Gal.
I have the papers for "crystalg" and the DIP definition matches the ones of "crystal2" which is pretty much a clone of that game.

Papers: https://imgur.com/a/TIoM8DT

  • Added correct DIPs for crystalg
  • Replaced "Unknown" to "Unused" where papers state they are unused
  • Changed default difficulty to 7 (specified in papers)
  • Changed Demo Sound default to off (specified in papers)

Some fixes for dips for Mahjong Crystal Gal.
I have the papers for "crystalg" and the DIP definition matches the ones of "crystal2" which is pretty much a clone of that game.

- Added correct DIPs for crystalg
- Replaced "Unknown" to "Unused" where papers state they are unused
- Changed default difficulty to 7 (specified in papers)
- Changed Demo Sound default to off (specified in papers)
@buffis
Copy link
Contributor Author

buffis commented May 23, 2025

Should probably clarify that I assume that the defaults of crystal2 is the same as crystalg, but I guess I can't know that 100%

@Osso13
Copy link
Member

Osso13 commented May 31, 2025

I'll defer to Vas about merging this, but I'll note that in MAME traditionally attract mode sounds are set on even if the manual states the default is off. This to make sound regressions testing more easy.

@angelosa
Copy link
Member

angelosa commented Jun 6, 2025

I'll defer to Vas about merging this, but I'll note that in MAME traditionally attract mode sounds are set on even if the manual states the default is off. This to make sound regressions testing more easy.

Yeah, that's the reason. Please add a note stating that manual suggests using default off but we need the on state by default.

@cuavas
Copy link
Member

cuavas commented Jun 6, 2025

Please don’t use “unused” unless you’ve confirmed from the code that they’re unused. Many games actually use these DIP switches for undocumented purposes (e.g. incomplete features, debug leftovers, etc.).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants