Skip to content

Add a Non Working Driver For Unknown 6 Ball Pinball Gambling. #13277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

flama12333
Copy link
Contributor

@flama12333 flama12333 commented Jan 25, 2025

originally but I closed and I deleted the branch by the way. oops
#12648

orientp meaning oriental pearl.
in spanish we called as pinball de 6 bolas.
the dump are from soccer santiago II dumped by jorge soto. im not sure if from or not because seem to be fixed by replacing the rom.

originally but I closed and I deleted the branch by the way.
mamedev#12648

orientp meaning oriental pearl.
in spanish will called pinball de 6 bolas.
since has mcu 
should flag as machine unemulated protection?
according to the sheet at

says ic protection which is mcu that was not been dumped.
causing to shown error 10
@flama12333
Copy link
Contributor Author

idk which nvram and opll, adpcm are mapped?

@flama12333
Copy link
Contributor Author

I guess I shouldn't have asked user that has dump due to few mistakes. now due to that the adpcm rom still not dumped.
also idk if is correct title etc.

@flama12333 flama12333 marked this pull request as ready for review May 25, 2025 06:14
@flama12333
Copy link
Contributor Author

flama12333 commented May 25, 2025

Also please credit Jorge soto at facebook that was dumped.
also has other dump of another machine private but my request ignored.

Copy link
Member

@Osso13 Osso13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, not really blocking stuff, just some suggestions

@@ -31818,6 +31818,9 @@ komocomo //
maddonnab // (c) 1995 Tuning
oneshot // no copyright notice

@source:misc/orientp.cpp
east8 //
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this isn't in alphabetical order

/*************************************************************************

// Features Notes Was from archived websited:
src: Chang yu website
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think copying entire parts of a website in the source is questionable, but I'll defer to others on this

void io_map(address_map &map);
void program_map(address_map &map);

protected:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please put the protected section above the private section. Also, if you don't need the machine_start() method, you can delete it entirely, unless you expect you will need it later on


void orientalpearl_state::orientp(machine_config &config)
{
/* basic machine hardware */
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use C++ style comments for one-liners

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants