Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Seal #9

Merged
merged 19 commits into from
Jun 12, 2024
Merged

Seal #9

merged 19 commits into from
Jun 12, 2024

Conversation

malcolmstill
Copy link
Owner

@malcolmstill malcolmstill commented Mar 31, 2024 •
edited
Loading

Description

  • Move parser.zig into biscuit-builder
  • Cleans up some of the lifetime stuff:
    • Biscuit.fromBytes can now take any mem.Allocator
    • Internally it now creates an ArenaAllocator (this is heap allocated because some objects created during Biscuit.fromBytes retain their allocator which would be the arena in Biscuit.fromBytes that is pointing to the stack-allocated ArenaAllocator)
    • A similar change is made to SerializedBiscuit
  • Adds fn seal to SerializedBiscuit that does the sealing (but doesn't serialize)

@malcolmstill
Move parser into builder...otherwise we need cyclic module dependency
bf01096
@malcolmstill
Seal tokens
c17b83a
@malcolmstill
Seal again fails
bf43b31
@malcolmstill
Rename function
9a820c2
@malcolmstill
Placeholder functions
408853d
@malcolmstill
Import
a7a2d21
@malcolmstill
WIP
6eac992
@malcolmstill
Internally create ArenaAllocator
5dfe893
@malcolmstill
Test sealing
7b1145c
@malcolmstill
Fix SerializedBiscuit with same changes as Biscuit in terms of heap-a…
98dfd9b 
…llocating ArenaAllocator
@malcolmstill
Partially working serialize (works after running seal, but not before?)
6203a4c
@malcolmstill
WIP
16c3b01
@malcolmstill
We can serialize tokens...kinda, I think. These tokens seem parsable …
c9e3594 
…by biscuit-rust...but if I try in some online proto tools they fail to parse. I assume this could be because we're using a proto3 enoder / decoder for a proto2 spec
@malcolmstill
Don't bother allocating
ba53bba
@malcolmstill
Fix test
f627e08
@malcolmstill
Remove temporary parser, instead parse functions that fail part way t…
c526b75 
…hrough consuming must reset state on errdefer
@malcolmstill
biscuit-builder no longer depends on biscuit-datalog
b1b077a
@malcolmstill
Zig 0.12.0
99283c9
@malcolmstill
zig 0.12.0
7a67e56
@malcolmstill malcolmstill merged commit e733306 into master Jun 12, 2024
6 checks passed
@malcolmstill malcolmstill deleted the malcolm/attenuate-seal-build branch June 12, 2024 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@malcolmstill