Delete unused objects

makotoyoshigoe · Sep 16, 2024 · 67f5c16 · 67f5c16
1 parent 08d4c19
commit 67f5c16
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 45 deletions.
diff --git a/wall_tracking_executor/include/wall_tracking_executor/wall_tracking_executor.hpp b/wall_tracking_executor/include/wall_tracking_executor/wall_tracking_executor.hpp
@@ -49,56 +49,39 @@ class WallTracking : public rclcpp::Node {
 	void navigateOpenPlace();
 	void pub_open_place_arrived(bool open_place_arrived);
 	void pub_open_place_detection(std::string open_place_detection);
-	void wall_tracking_flg_callback(std_msgs::msg::Bool::ConstSharedPtr msg);
 	void gnss_pose_with_covariance_callback(geometry_msgs::msg::PoseWithCovarianceStamped::ConstSharedPtr msg);
 	void goal_pose_callback(geometry_msgs::msg::PoseStamped::ConstSharedPtr msg);
 
-rclcpp_action::GoalResponse handle_goal(
-	[[maybe_unused]] const rclcpp_action::GoalUUID & uuid, 
-	[[maybe_unused]] std::shared_ptr<const WallTrackingAction::Goal> goal
-);
+	// For wall_tracking action server
+	rclcpp_action::GoalResponse handle_goal(
+		[[maybe_unused]] const rclcpp_action::GoalUUID & uuid, 
+		[[maybe_unused]] std::shared_ptr<const WallTrackingAction::Goal> goal
+	);
 
-rclcpp_action::CancelResponse handle_cancel(
-	const std::shared_ptr<GoalHandleWallTracking> goal_handle
-);
+	rclcpp_action::CancelResponse handle_cancel(
+		const std::shared_ptr<GoalHandleWallTracking> goal_handle
+	);
 
-void handle_accepted(
-	const std::shared_ptr<GoalHandleWallTracking> goal_handle
-);
+	void handle_accepted(
+		const std::shared_ptr<GoalHandleWallTracking> goal_handle
+	);
 
-void execute(
-	const std::shared_ptr<GoalHandleWallTracking> goal_handle
-);
+	void execute(
+		const std::shared_ptr<GoalHandleWallTracking> goal_handle
+	);
 
-// rclcpp_action::GoalResponse nav_handle_goal(
-// 	[[maybe_unused]] const rclcpp_action::GoalUUID & uuid, 
-// 	[[maybe_unused]] std::shared_ptr<const NavigationToPose::Goal> goal
-// );
-
-rclcpp_action::CancelResponse nav_handle_cancel(
-	const std::shared_ptr<GoalHandleNavigateToPose> goal_handle
-);
-
-void nav_handle_accepted(
-	const std::shared_ptr<GoalHandleNavigateToPose> goal_handle
-);
-
-void nav_execute(
-	const std::shared_ptr<GoalHandleNavigateToPose> goal_handle
-);
-
-void goalResponceCallback(const std::shared_ptr<GoalHandleNavigateToPose> &goal_handle);
-void feedbackCallback([[maybe_unused]] typename std::shared_ptr<GoalHandleNavigateToPose>, 
-        			[[maybe_unused]] const std::shared_ptr<const typename NavigateToPose::Feedback> feedback);
-void resultCallback(const GoalHandleNavigateToPose::WrappedResult & result);
+	// For navigate_to_pose action client
+	void goalResponceCallback(const std::shared_ptr<GoalHandleNavigateToPose> &goal_handle);
+	void feedbackCallback([[maybe_unused]] typename std::shared_ptr<GoalHandleNavigateToPose>, 
+						[[maybe_unused]] const std::shared_ptr<const typename NavigateToPose::Feedback> feedback);
+	void resultCallback(const GoalHandleNavigateToPose::WrappedResult & result);
 
 private:
 	rclcpp::Subscription<sensor_msgs::msg::LaserScan>::SharedPtr scan_sub_;
 	rclcpp::Publisher<geometry_msgs::msg::Twist>::SharedPtr cmd_vel_pub_;
 	rclcpp::Subscription<sensor_msgs::msg::NavSatFix>::SharedPtr gnss_sub_;
 	rclcpp::Publisher<std_msgs::msg::Bool>::SharedPtr open_place_arrived_pub_;
 	rclcpp::Publisher<std_msgs::msg::String>::SharedPtr open_place_detection_pub_;
-	rclcpp::Subscription<std_msgs::msg::Bool>::SharedPtr wall_tracking_flg_sub_;
 	rclcpp::Subscription<geometry_msgs::msg::PoseWithCovarianceStamped>::SharedPtr gnss_pose_with_covariance_sub_;
 	rclcpp::Subscription<geometry_msgs::msg::PoseStamped>::SharedPtr goal_pose_sub_;
 
@@ -111,7 +94,6 @@ void resultCallback(const GoalHandleNavigateToPose::WrappedResult & result);
 
 	rclcpp_action::Client<NavigateToPose>::SendGoalOptions nav_send_goal_options_;
 	rclcpp_action::Client<NavigateToPose>::SharedPtr navigation_action_client_;
-	// rclcpp_action::Server<NavigationToPose>::SharedPtr navigation_action_srv_;
 
 	float distance_from_wall_;
 	float distance_to_stop_;

diff --git a/wall_tracking_executor/src/wall_tracking_executor.cpp b/wall_tracking_executor/src/wall_tracking_executor.cpp
@@ -79,9 +79,6 @@ void WallTracking::init_sub()
     gnss_sub_ = this->create_subscription<sensor_msgs::msg::NavSatFix>(
         "gnss/fix", rclcpp::QoS(10),
         std::bind(&WallTracking::gnss_callback, this, std::placeholders::_1));
-    wall_tracking_flg_sub_ = this->create_subscription<std_msgs::msg::Bool>(
-        "wall_tracking_flg", rclcpp::QoS(10),
-        std::bind(&WallTracking::wall_tracking_flg_callback, this, std::placeholders::_1));
     gnss_pose_with_covariance_sub_ = this->create_subscription<geometry_msgs::msg::PoseWithCovarianceStamped>(
         "gnss_pose_with_covariance", rclcpp::QoS(10),
         std::bind(&WallTracking::gnss_pose_with_covariance_callback, this, std::placeholders::_1));
@@ -223,11 +220,6 @@ void  WallTracking::gnss_pose_with_covariance_callback(geometry_msgs::msg::PoseW
     else gnss_nan_ = false;
 }
 
-void WallTracking::wall_tracking_flg_callback(std_msgs::msg::Bool::ConstSharedPtr msg)
-{
-    wall_tracking_flg_ = msg->data;
-}
-
 float WallTracking::lateral_pid_control(float input)
 {
     float e = input - distance_from_wall_;