Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Natasha Chitter Challenge #2176

Open
wants to merge 20 commits into
base: main
Choose a base branch
from
Open

Natasha Chitter Challenge #2176

wants to merge 20 commits into from

Conversation

natashabuckham
Copy link

No description provided.

@natashabuckham
files setup
b85344c
@natashabuckham
added bcrypt and sessions setup
80a1d5f
@natashabuckham
html skeleton and route plan
ad6d406
@natashabuckham
bcrypt gem installation fixed, database connect method fixed, peep re…
a86623a 
…po all method tested
@natashabuckham
peep repo create method tested
d3e320d
@natashabuckham
updated seeds structure to account for foreign key constraint
99f3d2b
@natashabuckham
user repo create method tested
e8ee635
@natashabuckham
rewritten user repo create test
74c0705
@natashabuckham
user repo find by email method tested
408a9fd
@natashabuckham
user repo find by id method tested
cde3440
@natashabuckham
get / route tested
6713560
@natashabuckham
get /signup route tested
c595618
@natashabuckham
post /signup route tested
8f88a87
@natashabuckham
get /login route tested
a6fb80e
@natashabuckham
post /login route tested
45fe0b7
@natashabuckham
POST /login wrong password route tested
e70a324
@natashabuckham
get /peeps/new route tested
9b8f9bf
@natashabuckham
post /peeps route tested
03d5858
@natashabuckham
update password input type in forms, update form submit button labels
e3139be
@natashabuckham
added comments for future work
3ef3a5b
jonpillay
jonpillay reviewed Apr 12, 2023
View reviewed changes
Gemfile.lock
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Could you check all the gems are in use please? Thank you.

jonpillay
jonpillay reviewed Apr 12, 2023
View reviewed changes
app.rb
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent naming convention

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unsure about logic convention, something to research

jonpillay
jonpillay reviewed Apr 12, 2023
View reviewed changes
route_plan.md
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent documentation. Thank you :-)

jonpillay
jonpillay reviewed Apr 12, 2023
View reviewed changes
spec/app_spec.rb
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent full tests

jonpillay
jonpillay reviewed Apr 12, 2023
View reviewed changes
spec/peep_repository_spec.rb
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and complete

jonpillay
jonpillay reviewed Apr 12, 2023
View reviewed changes
Copy link

@jonpillay jonpillay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent clean code. Maybe look into flash for messages and help with less views (erb files)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonpillay jonpillay jonpillay left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@natashabuckham @jonpillay