Work In Progress Chitter app #2172
Conversation
app.rb
Outdated
| end | ||
|
|
||
| get '/' do | ||
| @all_peeps = PeepRespository.new.all_by_rev_date_order_with_author |
app.rb
Outdated
| end | ||
|
|
||
| get '/login' do | ||
| if session[:user_id] |
There was a problem hiding this comment.
think about developing a controller method/class.
| it "displays all peeps in reverse chronological order" do | ||
| response = get('/') | ||
| expect(response.status).to eq(200) | ||
| expect(response.body).to match(/Big Brother is watching you @wsmith[\s\S]*@wsmith & @smhanna - this is jam hot, this is jam hot[\s\S]*We shall meet in the place where there is no darkness/) |
There was a problem hiding this comment.
not sure I agree with such a large expects comment.
maybe break this up.
lib/peep_repository.rb
Outdated
There was a problem hiding this comment.
is it better you make a request for the data then sort it accordingly.
spec/seeds.sql
Outdated
There was a problem hiding this comment.
I would create a file called seeds to store all my database information with the spec.
e.g put chitter.sql and chitter_test.sql in the same location.
| @@ -0,0 +1,3 @@ | |||
| class User | |||
| attr_accessor :id, :name, :username, :email, :password | |||
There was a problem hiding this comment.
from the Peeps table I can see you have the columns user and user_id, then in Users table you have the column username. reckon you can drop a few of these columns as the project progresses. I'm guilty of the same thing.
lib/user_repository.rb
Outdated
| if stored_password == submitted_password | ||
| return { success: true, username: user.username, user_id: user.id } | ||
| else | ||
| return { success: false, reason: "incorrect password "} |
There was a problem hiding this comment.
I like the reason statement. will take this for my own project.
schema_recipe.md
Outdated
There was a problem hiding this comment.
well planned out. might be worth adding a .md file to the seeds db file i suggested adding with some of the info below in it.
spec/user_repository_spec.rb
Outdated
| expect(repo.all.last.name).to eq "John Smith" | ||
| expect(repo.all.last.email).to eq "[email protected]" | ||
| end | ||
| xit "fails to add them given any missing info" do |
There was a problem hiding this comment.
look at developing a validation method to run on the inputs incorporating a conditional statement to decide to run the create new user method.
def invalid_request_parameters?
return true if params[:title].nil? || params[:title].empty? ||
params[:content].nil? || params[:content].empty?
false
end
views/login_denied.erb
Outdated
There was a problem hiding this comment.
This is quite cool! im not sure how dynamic HTML is at controlling conditional statements will be interesting to get your take on it!
Began implementation of home page, using sessions to display a form to create new peep only if the user is logged in. Began implementation of login and register pages.