Chitter-challenge - Tara #1215
Chitter-challenge - Tara #1215
Conversation
There was a problem hiding this comment.
Really nice looking app! For some reason I couldn't get the peeps to show up when I submitted them though...I just got a list of #'s, but it could very well have been me setting up the database wrong.
The only things I really noticed were the obsolete feature tests and the CSS being in the view, but the code looks pretty good other than that. I defo enjoyed looking at it since I didn't give myself nearly enough time to get very far!
Nice job :)
| @@ -1,8 +1,17 @@ | |||
| <!DOCTYPE html> | |||
| <html> | |||
| <head> | |||
| <meta charset="utf-8"> | |||
| <title></title> | |||
| <style> | |||
There was a problem hiding this comment.
To keep your view files a bit cleaner, you can create a seperate CSS file and at a link to it in the html. Dom sent me this for the RPS game last week which helped a bit: https://github.com/webdevjeffus/css-for-sinatra#putting-it-in-place
| @@ -5,4 +5,10 @@ | |||
| visit('/') | |||
| expect(page).to have_button 'Sign up' | |||
| end | |||
|
|
|||
| scenario 'Allow user to enter details' do | |||
There was a problem hiding this comment.
These two feature test probably could have been merged into one. In this test, capybara is clicking the signup button in order to let the user enter details. If the page didn't have the sign up button (which the first feature test is testing for), then the test would still fail, so you're still covering yourself.
Please see the readme to show the areas of the challenge I have struggled with and have not been able to complete.