Skip to content
This repository has been archived by the owner on Sep 28, 2022. It is now read-only.

upgrade to dapple 0.8 / solidity 0.4 #59

Merged
merged 9 commits into from
Nov 5, 2016
Merged

upgrade to dapple 0.8 / solidity 0.4 #59

merged 9 commits into from
Nov 5, 2016

Conversation

rainbreak
Copy link
Contributor

@rainbreak rainbreak commented Oct 4, 2016

Fixes #57, #55.

TODO:

  • add solidity version pragma "pragma solidity ^0.4.2;"
  • fix test contract deployment failures (throw on deploy) [pending ethereumjs-vm update]
  • rebase and update ci

The latter appears to be dapple / solidity issue, probably exposed by the largish setUp method in the auction tests (which creates several new contracts).

The global setUp method could be replaced by some use of dapple script - this would set the initial chain state from which each unit test would fork from.

@rainbreak
Copy link
Contributor Author

rainbreak commented Oct 8, 2016

@mhhf: I still can't work out these deployment failures. There seems to be some relation to test contract size, but it isn't at all direct.

Some data points:

  • I split up the AuctionManagerTest (which was failing to deploy) and then found that there were more deployment failures in unchanged contracts that didn't fail to deploy before.
  • ForwardSplittingTest: dapple test -r forwardsplittingtest fails to deploy, dapple test is ok
  • ClaimTest: dapple test -r claimtest deploys and passes, dapple test fails to deploy
  • BidTest: dapple test -r bidtest fails to deploy, dapple test fails to deploy
  • ReverseGasTest: dapple test -r reversegastest deploys and passes, dapple test fails to deploy

It feels like a race condition, but ¯_(ツ)_/¯

@rainbreak
Copy link
Contributor Author

@mhhf: ethereumjs/ethereumjs-monorepo#91 fixes the deployment failures :D

@mhhf
Copy link

mhhf commented Oct 18, 2016

Awesome :D
Once it get merged into etherumjs-vm i'll build it into dapple immediately!

@rainbreak rainbreak merged commit 431d232 into master Nov 5, 2016
@ghost ghost deleted the migrate branch May 7, 2017 14:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Solidity 0.4.1 compatibility
2 participants