This repository has been archived by the owner on Sep 28, 2022. It is now read-only.

division by zero #55

Open

jorisbontje opened this issue Sep 12, 2016 · 1 comment

Labels

ready

Contributor

jorisbontje commented Sep 12, 2016

pre Solidity 0.4, division by zero returns 0 instead of throwing.
we might want to assert divisors to be > 0, such as
https://github.com/makerdao/token-auction/blob/master/contracts/auction.sol#L213

rainbreak added the ready label

Contributor

rainbreak commented Oct 3, 2016

I think that upgrading to 0.4 (#57) and using a pragma is sufficient here.

rainbreak mentioned this issue

upgrade to dapple 0.8 / solidity 0.4 #59

Merged

3 tasks

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.