Mainnet spell 2025-02-21

[SidestreamStrongStrawberry]

Description

Spell crafted based on the relevant Executive Sheet.

Contribution Checklist

• PR title starts with (PE-<TICKET_NUMBER>)
• Code approved
• Tests approved
• CI Tests pass

Checklist

• Every contract variable/method declared as public/external private/internal
• Consider if this PR needs the officeHours modifier override
• Verify expiration (30 days unless otherwise specified)
• Verify hash in the description matches here
• Validate all addresses used are in changelog or known
• Notify any external teams affected by the spell so they have the opportunity to review
• Deploy spell ETH_GAS_LIMIT="XXX" ETH_GAS_PRICE="YYY" make deploy
• Verify mainnet contract on etherscan
• Change test to use mainnet spell address and deploy timestamp
• Run make archive-spell or make date="YYYY-MM-DD" archive-spell to make an archive directory and copy DssSpell.sol, DssSpell.t.sol, DssSpell.t.base.sol, and DssSpellCollateralOnboarding.sol
• squash and merge this PR

[SidestreamStrongStrawberry]

NOTE: I've increased gas limit for the tests due to the error arising from testArbitrumTokenGatewayIntegration function. More specifically, the error EvmError: MemoryOOG is thrown by arbitrumDomain.relayFromHost(false) line in the test, when this env variable is not present. Chosen FOUNDRY_GAS_LIMIT value is arbitrary and is simply twice bigger than the default value specified in the foundry docs. This adjustment should not affect execution of the spell on the mainnet.

[oldchili]

Doesn't make a huge difference, but you can use USDS_JOIN and avoid the conversion.

[SidestreamStrongStrawberry]

Thx! addressed in 26d405a