Skip to content
This repository has been archived by the owner on Sep 28, 2022. It is now read-only.

Bittrex fix trades #101

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Bittrex fix trades #101

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
824a8bc
fixed timestamp issue for our_trades and all_trades
Jun 12, 2019
a717753
removed excess imports
Jun 12, 2019
c288bbf
Merge remote-tracking branch 'upstream/master'
Jul 10, 2019
22b6b68
Merge remote-tracking branch 'upstream/master'
ith-harvey Sep 18, 2019
865e99c
Merge remote-tracking branch 'upstream/master'
ith-harvey Sep 25, 2019
9acb0f2
Merge remote-tracking branch 'upstream/master'
ith-harvey Sep 26, 2019
c7c249e
Merge remote-tracking branch 'upstream/master'
ith-harvey Oct 28, 2019
bf5ab23
updated and fixed our trades issue
ith-harvey Oct 28, 2019
adf7b48
updated trades
ith-harvey Oct 30, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyexchange/bittrex.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,7 @@ def get_trades(self, pair: str, page_number: int = 1) -> List[Trade]:
pair=item['Exchange'],
is_sell=item['OrderType'] == 'LIMIT_SELL',
price=Wad.from_number(item['PricePerUnit']),
amount=Wad.from_number(item['Quantity'])), result))
amount=Wad.from_number(item['Quantity'] - item['QuantityRemaining'])), result))

def get_all_trades(self, pair: str, page_number: int = 1) -> List[Trade]:
assert(isinstance(pair, str))
Expand Down
4 changes: 2 additions & 2 deletions tests/manual_test_bittrex.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,8 @@
# print(f"Balance: {bittrex.get_balances()}")
# print(bittrex.get_trades('ETH-DAI'))
# print(bittrex.get_all_trades('ETH-DAI'))
print(bittrex.cancel_order("16bb9e73-92b6-4e1f-8f59-8d34397eff47"))

print(bittrex.get_orders('ETH-DAI'))
print(bittrex.get_trades('BTC-DAI'))
#print(bittrex.get_all_trades('BTC-DAI'))
print(f"Balance: {bittrex.get_balances()}")
# print(bittrex.get_all_trades('BTC-AAA'))