-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: create d3m checklist #41
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TL;DR: 1 fix and several grammar/phrasing nits.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found some redundant checks that might potentially be removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR adds D3M onboarding checklist.
Superset of all D3M onboarding action list
dss-direct-deposit/D3MCoreInstance
,dss-direct-deposit/D3MInit
,dss-direct-deposit/D3MInstance
independencies
dir (from here)plan
: plan contract addresspool
: pool contract addressoracle
: oracle contract addresshub
: D3M hub contract address (from chainlog)mom
: D3M mom contract address (from chainlog)maxLine
: Debt ceiling (auto line value)gap
: Max Value between current debt and line to be set (auto line value)ttl
: Min time to pass before a new increase (auto line value)tau
: Time until you can write off the debt [sec]king
: address who will get rewardsadai
: adai addressstableDebt
: stableDebtToken addressvariableDebt
: variableDebtToken addressbuffer
: Target DAI liquidity to keep in the pool [WAD]adai
: adai token addressD3MAaveV2TypeRateTargetPlan.sol
contract was deployedD3MAaveRateTargetPlanConfig
inD3MInit.sol
should be used. WhenD3MAaveTypeBufferPlan.sol
contract was deployed we can useD3MAaveBufferPlanConfig
king
: address who will get rewardscdai
: cdai token address[comptroller](https://github.com/compound-finance/compound-protocol/blob/master/contracts/Comptroller.sol)
: comptroller addresscomp
: address of the COMP tokenbarb
: target Interest Rate Per Block [wad]cdai
: cdai token addresstack
: supported rate modelsdelegate
: cDai supported implementationsvault
: ERC4626 standard vault addressoperator
: D3M Operator Plan addressD3MInit.initCommon
(code), in d3m repository)ilk.pool
address inhub
contract (code)ilk.plan
address inhub
contract (code)ilk.tau
value inhub
contract (code)hub
address inoracle
contract (code)ilk.pip(price feed)
in spotter (code)ilk.mat(liquidation ratio)
in spotter (code)vat
(code)jug
(code)ilk.line
invat
(code)ilk
toILK_REGISTRY
(code)pool
,plan
,oracle
contract to chainlog withprefix
(code)pool.hub
address matches DIRECT_HUB address on chainlogpool.ilk
name matchedilk
pool.vat
address matches MCD_VAT address on chainlogpool.dai
address matches MCD_DAI address on chainlogpool.adai
address matchesadai
addresspool.stableDebt
address matchesstableDebt
addresspool.variableDebt
address matches variableDebt addresspool.king
valuepool.hub
address matcheshub
address (code)pool.ilk
name matchedilk
(code)pool.vat
address matchesvat
address (code)pool.usdsJoin
address matchesusdsJoin
(code)pool.usds
address matchesusds
(code)pool.daiJoin
address matchesdaiJoin
(code)pool.dai
address matchesdai
address (code)pool.ausds
address matchesausds
address (code)pool.stableDebt
address matchesstableDebt
address (code)pool.variableDebt
address matches variableDebt address (code)pool.king
value (code)plan.adai
matchesadai
(code)plan.buffer
(code)pool.hub
address matcheshub
address (code)pool.ilk
name matchedilk
(code)pool.vat
address matchesvat
address (code)pool.dai
address matchesdai
address (code)pool.comptroller
address matchescomptroller
address (code)pool.comp()
address matchescomp
address (code)pool.cDai
address matches cDai address (code)pool.king
(code)plan.tacks(tack)
returns 1 (code)cdai.interestRateModel
matchestack
(code)plan.delegates(delegate)
returns 1 (code)cdai.implementation
matchesdelegate
(code)plan.cDai
matchescDai
address (code)plan.barb
(code)pool.hub
address matcheshub
address (code)pool.ilk
name matchedilk
(code)pool.vat
address matchesvat
address (code)pool.dai
address matchesdai
address (code)pool.vault
address matches givenvault
address (code)morpho
before but it will be used for next AaveV3USDS D3M (source)plan.operator
address to given operator address