Add tenderly-related checks #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -353,6 +353,13 @@ _Insert your local test logs here_ | |||
| * [ ] Check again that the PR did not modify the `DssExecLib.address` file (e.g. look under the 'Files Changed' PR tab, etc.) | |||
| * [ ] Ensure Etherscan `Libraries Used` matches DssExecLib [Latest Release](https://github.com/makerdao/dss-exec-lib/releases/latest) | |||
| * [ ] (For your tests to be accurate) git submodule hash matches [dss-exec-lib](https://github.com/makerdao/dss-exec-lib/releases/latest) latest release's tag commit and inspect diffs if doesn't match to ensure expected behaviour (Currently Non-Critical pending the next DssExecLib release, double check that the ExecLib used by the contract matches the latest release) | |||
| * Tenderly Testnet checks | |||
| * [ ] A testnet with the name matching spell description is found at [maker dashboard](https://dashboard.tenderly.co/maker/virtual-networks) | |||
There was a problem hiding this comment.
nit,
Suggested change
| * [ ] A testnet with the name matching spell description is found at [maker dashboard](https://dashboard.tenderly.co/maker/virtual-networks) | |
| * [ ] The testnet name matches spell description can be found at [maker dashboard](https://dashboard.tenderly.co/maker/virtual-networks) |
There was a problem hiding this comment.
The linked dashboard contains a list of testnets, so the first step is to identify which testnet is relevant to this particular spell. I would keep this check as is if you don't mind
| * Tenderly Testnet checks | ||
| * [ ] A testnet with the name matching spell description is found at [maker dashboard](https://dashboard.tenderly.co/maker/virtual-networks) | ||
| * [ ] The testnet name is unique (previous testnets does not have the same name) | ||
| * [ ] Cast transaction is set to the correct "receiver" (matches deployed spell address) |
There was a problem hiding this comment.
Suggested change
| * [ ] Cast transaction is set to the correct "receiver" (matches deployed spell address) | |
| * [ ] Cast transactions are set to the correct "receivers" (matches deployed spell address) |
There was a problem hiding this comment.
There is only one cast transaction in the execution of the spell. Other transactions displayed in the public explorer are either "system transactions" or is a schedule call.
amusingaxl
approved these changes
Feb 14, 2024
0xdecr1pto
approved these changes
Feb 14, 2024
SidestreamStrongStrawberry
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #25