Skip to content

Commit

Permalink
chore: apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: oddaf <[email protected]>
  • Loading branch information
amusingaxl and oddaf authored Nov 20, 2024
1 parent 1069a8a commit 4c1dd49
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions spell/rwa-checklists.md
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
* [ ] `RwaJar`
* [ ] contract is verified on etherscan
* [ ] ensure `0.6.12` solc version is used
* [ ] ensure optimization are off
* [ ] ensure optimizations are off
* [ ] ensure license is specified (SPDX in code or otherwise)
* [ ] ensure source matches [GitHub code](https://github.com/makerdao/rwa-toolkit/blob/8d30ed2cb657641253d45b57c894613e26b4ae1b/src/jars/RwaJar.sol) and it's consistent with previous RWA onboarding
* [ ] constructor arg matches [`ChainLog`](https://chainlog.makerdao.com/)
Expand All @@ -54,7 +54,7 @@
* [ ] `RwaInputConduit<2>`/`RwaSwapInputConduit<2>`
* [ ] contract is verified on etherscan
* [ ] ensure `0.6.12` solc version is used
* [ ] ensure optimization are off
* [ ] ensure optimizations are off
* [ ] ensure license is specified (SPDX in code or otherwise)
* [ ] ensure source matches [GitHub code](https://github.com/makerdao/rwa-toolkit/tree/8d30ed2cb657641253d45b57c894613e26b4ae1b/src/conduits) and it's consistent with previous RWA onboarding
* [ ] constructor args are correct and match [chainlog](https://chainlog.makerdao.com/)
Expand All @@ -69,7 +69,7 @@
* [ ] `RwaOutputConduit<2>`/`RwaSwapOutputConduit`
* [ ] contract is verified on etherscan
* [ ] ensure `0.6.12` solc version is used
* [ ] ensure optimization are off
* [ ] ensure optimizations are off
* [ ] ensure license is specified (SPDX in code or otherwise)
* [ ] ensure source matches [GitHub code](https://github.com/makerdao/rwa-toolkit/tree/8d30ed2cb657641253d45b57c894613e26b4ae1b/src/conduits) and it's consistent with previous RWA onboarding
* [ ] constructor args are correct and match [chainlog](https://chainlog.makerdao.com/)
Expand Down Expand Up @@ -103,7 +103,7 @@
* [ ] `hope` (operator, pause proxy)
* [ ] `mate` (operator, pause proxy as fallback if required)
* [ ] `kiss` (whitelist for `urn` destination address `who`)
* [ ] Filable (`RwaSwapOutputConduit` and `RwaSwapInputConduit`)
* [ ] Fileable (`RwaSwapOutputConduit` and `RwaSwapInputConduit`)
* [ ] `quitTo` (`file` the appropriate address for conduits per technical assessment)
* [ ] New Chainlog Entries
* [ ] `RWAXYZ`
Expand Down

0 comments on commit 4c1dd49

Please sign in to comment.