Upgradable L1TokenBridge and L2TokenBridge #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
telome seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
added 2 commits
October 1, 2024 14:56
telome
commented
Oct 1, 2024
| @@ -44,6 +47,7 @@ contract L2TokenBridgeSpell { | |||
| l2Bridge = L2TokenBridgeLike(l2Bridge_); | |||
| } | |||
|
|
|||
| function upgradeToAndCall(address newImp, bytes memory data) external { l2Bridge.upgradeToAndCall(newImp, data); } | |||
There was a problem hiding this comment.
Note that I chose to ignore that this function is normally payable to keep things simpler, as it doesn't seem useful to be able to pass value to the initialization function (and the L2GovernanceRelay doesn't explicitly supports receiving ether, though there is still the selfdestruct workaround).
sunbreak1211
reviewed
Oct 1, 2024
sunbreak1211
reviewed
Oct 1, 2024
sunbreak1211
reviewed
Oct 1, 2024
sunbreak1211
reviewed
Oct 1, 2024
sunbreak1211
reviewed
Oct 1, 2024
oldchili
reviewed
Oct 2, 2024
oldchili
reviewed
Oct 3, 2024
deploy/TokenBridgeInit.sol
Outdated
| @@ -108,5 +114,6 @@ library TokenBridgeInit { | |||
| dss.chainlog.setAddress(cfg.govRelayCLKey, address(l1GovRelay)); | |||
| dss.chainlog.setAddress(cfg.escrowCLKey, address(escrow)); | |||
| dss.chainlog.setAddress(cfg.l1BridgeCLKey, address(l1Bridge)); | |||
| dss.chainlog.setAddress(cfg.l1BridgeImpCLKey, l1BridgeInstance.bridgeImp); | |||
There was a problem hiding this comment.
Suggested change
| dss.chainlog.setAddress(cfg.l1BridgeImpCLKey, l1BridgeInstance.bridgeImp); | |
| dss.chainlog.setAddress(cfg.l1BridgeImpCLKey, l1BridgeInstance.bridgeImp); |
Or otherwise align the entire column.
oldchili
approved these changes
Oct 3, 2024
added 2 commits
October 4, 2024 15:04
oldchili
approved these changes
Oct 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.