Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exports should group by name instead of all into one #45

Merged
merged 2 commits into from
Aug 14, 2024

Conversation

hexonaut
Copy link
Collaborator

@hexonaut hexonaut commented Aug 12, 2024

Fixes an issue where exporting to multiple jsons at once would not separate by name.

Ex)

ScriptTools.exportContract("A", "someContractA", address(123));
ScriptTools.exportContract("B", "someContractB", address(456));

before this would output both contracts someContractA and someContractB to the B.json. With this change both A.json and B.json will have only their 1 respective contract.

@hexonaut hexonaut requested a review from amusingaxl August 12, 2024 13:28
@hexonaut hexonaut self-assigned this Aug 12, 2024
@DaiFoundation-DevOps
Copy link

DaiFoundation-DevOps commented Aug 12, 2024

CLA assistant check
All committers have signed the CLA.

@amusingaxl
Copy link
Contributor

Can you please explain a little bit further what issue you are trying to fix here?

@hexonaut
Copy link
Collaborator Author

Updated OP

Copy link
Contributor

@amusingaxl amusingaxl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This actually makes sense. LGTM.

@hexonaut hexonaut merged commit eab651b into master Aug 14, 2024
3 checks passed
@hexonaut hexonaut deleted the fix-export-grouping branch August 14, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants