Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WEB-3087] fix: project_id handling in cycle create write serializer #6358

Merged
merged 2 commits into from
Jan 9, 2025

Conversation

gurusainath
Copy link
Collaborator

@gurusainath gurusainath commented Jan 8, 2025

Description

  • Updated the cycle create write serializer to properly retrieve project_id from the current instance.
  • Ensured that project_id is correctly assigned and saved during cycle creation.

Type of Change

  • Improvement (change that would cause existing functionality to work as expected)

References

[WEB-3087]

Summary by CodeRabbit

  • Bug Fixes

    • Fixed a syntax error in the CycleUserPropertiesSerializer.
    • Improved project ID retrieval logic in cycle-related serializers.
  • Enhancements

    • Updated cycle view methods to provide additional context for serializers.
    • Enhanced flexibility in handling project-specific data during cycle creation and updates.

Copy link
Contributor

coderabbitai bot commented Jan 8, 2025

Walkthrough

The pull request introduces modifications to the cycle-related serializers and views in the API server. The changes primarily focus on enhancing the project_id retrieval logic in the CycleWriteSerializer and updating the serializer initialization in the CycleViewSet. A syntax error in the CycleUserPropertiesSerializer is also addressed by adding a missing comma in the read_only_fields declaration.

Changes

File Change Summary
apiserver/plane/app/serializers/cycle.py - Updated project_id retrieval logic in CycleWriteSerializer to include context-based fallback
- Fixed syntax error by adding missing comma in CycleUserPropertiesSerializer read_only_fields
apiserver/plane/app/views/cycle/base.py - Removed unused import statements
- Added project_id context to CycleWriteSerializer in create and partial_update methods

Possibly related PRs

Suggested reviewers

  • NarayanBavisetti
  • sriramveeraghanta

Poem

🐰 Cycles spin, data flows free
Context added with glee
A comma here, a tweak there
Serializers dance without a care
Code hops forward, bright and clear! 🚀


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 070aec6 and 41f947e.

📒 Files selected for processing (1)
  • apiserver/plane/app/serializers/cycle.py (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • apiserver/plane/app/serializers/cycle.py
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: Analyze (javascript)

Finishing Touches

  • 📝 Generate Docstrings

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@pushya22 pushya22 merged commit 448a34a into preview Jan 9, 2025
12 of 14 checks passed
@pushya22 pushya22 deleted the chore-issue-cycle-project branch January 9, 2025 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants