Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WEB-2686] chore: added draft cycle and module in draft issue #5854

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

NarayanBavisetti
Copy link
Collaborator

@NarayanBavisetti NarayanBavisetti commented Oct 17, 2024

chore:

  • now when moving the issue from draft to a new issue, modules and cycles can be added in a single request.

Issue Link: WEB-2686

Summary by CodeRabbit

  • New Features

    • Enhanced flexibility in creating issues from drafts by utilizing request data for cycle and module information.
    • Improved activity logging to reflect new data sources for cycle and module creation.
  • Bug Fixes

    • Streamlined logic for handling cycle and module IDs during issue creation.
  • Chores

    • Simplified comments regarding draft issue deletion process.

Copy link
Contributor

coderabbitai bot commented Oct 17, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The changes in this pull request focus on the WorkspaceDraftIssueViewSet class within the apiserver/plane/app/views/workspace/draft.py file. The primary modification involves the create_draft_to_issue method, which now utilizes cycle and module IDs from the request data instead of the draft issue's attributes. This adjustment enhances the method's flexibility in handling input data. Additionally, the logic for creating CycleIssue and ModuleIssue instances has been updated, and comments regarding the deletion of related draft issue modules and cycles have been removed.

Changes

File Path Change Summary
apiserver/plane/app/views/workspace/draft.py Modified create_draft_to_issue to use request data for cycle and module IDs; removed comments regarding deletion of draft issue modules and cycles. Updated activity logging for clarity.

Possibly related PRs

Suggested labels

🌐frontend, 🧹chore

Suggested reviewers

  • sriramveeraghanta
  • pablohashescobar

Poem

In the meadow where drafts do play,
New IDs come from requests today.
No more cycles lost in the fray,
Flexibility leads the way!
Hopping along, we cheer and sway,
For changes bright, hip-hip-hooray! 🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@pushya22 pushya22 merged commit b6a7e45 into preview Oct 17, 2024
12 of 15 checks passed
@pushya22 pushya22 deleted the chore/draft-issue-cycle-module branch October 17, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants