-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WEB-2626] chore: removed the deleted issue's count #5837
Conversation
WalkthroughThe changes in this pull request involve updates to various classes and methods to enhance the filtering of issues marked as deleted. Specifically, the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (2)
apiserver/plane/utils/analytics_plot.py (2)
Line range hint
1-280
: Summary of changes in burndown_plot functionThe modifications in this file are focused on using a custom manager (
issue_objects
) for Issue queries in theburndown_plot
function. This change is consistently applied for both cycle and module-related queries.These alterations align with the PR objective of removing deleted issues from counts, likely through the use of a custom manager that filters out deleted issues. The rest of the function and file remain unchanged, preserving the existing logic and structure.
Consider documenting the behavior of the
issue_objects
manager in a comment within this file or in the model definition to make it clear to other developers why this custom manager is used and what filtering it applies.
chore:
Issue Link: WEB-2626
Summary by CodeRabbit
New Features
Bug Fixes