Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: export for analytics and issues #5815

Merged
merged 1 commit into from
Oct 12, 2024
Merged

Conversation

pablohashescobar
Copy link
Collaborator

@pablohashescobar pablohashescobar commented Oct 12, 2024

fix: export for analytics and csv

Summary by CodeRabbit

  • New Features
    • Enhanced logic for fetching assignee details, improving avatar URL retrieval.
  • Bug Fixes
    • Corrected control flow in the S3 upload function by fixing indentation issues.
  • Chores
    • Removed unnecessary ACL settings from S3 upload parameters.

Copy link
Contributor

coderabbitai bot commented Oct 12, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The changes in this pull request enhance the functionality of two files: analytic_plot_export.py and export_task.py. In analytic_plot_export.py, the get_assignee_details function is improved to utilize Django's Q objects for more sophisticated filtering of assignee details. An annotation for constructing the assignees__avatar_url has been added. In export_task.py, the upload_to_s3 function has had its ACL setting removed from the S3 upload parameters, and the indentation of an else block has been corrected.

Changes

File Path Change Summary
apiserver/plane/bgtasks/analytic_plot_export.py Enhanced get_assignee_details function with Django's Q objects and added annotation for avatar_url. Added import statements for Q, Case, Value, When, and Concat.
apiserver/plane/bgtasks/export_task.py Removed ACL setting from ExtraArgs in upload_to_s3 function and corrected indentation of else block.

Possibly related PRs

  • [WEB-2430] fix: issue exports for project #5579: The changes in export_task.py related to the update_json_row and update_table_row functions involve modifications to how assignees are handled, which is directly relevant to the enhancements made in the upload_to_s3 function in the main PR, as both PRs focus on improving the handling of assignees in export-related functionalities.

Suggested labels

⚙️backend

Suggested reviewers

  • gurusainath
  • pushya22

🐰 In the code, I hop and play,
Enhancing logic day by day.
With avatars and tasks in sight,
Our exports now take flight!
A little tweak, a careful glance,
Together we code, together we dance! 🎉


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@pablohashescobar pablohashescobar changed the title fix: export for analytics and csv fix: export for analytics and issues Oct 12, 2024
@sriramveeraghanta sriramveeraghanta merged commit 701af73 into preview Oct 12, 2024
11 of 14 checks passed
@sriramveeraghanta sriramveeraghanta deleted the fix-exports branch October 12, 2024 20:41
@sriramveeraghanta sriramveeraghanta added this to the v0.24.0 milestone Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants