Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add - to domain part of regex for email #151

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

TheZoker
Copy link
Contributor

This PR adds the ability to have a - in the domain part of the email. I'm still not sure if this regex is the best way to test for emails. Maybe there are other emails that are not covered by this.

@TheZoker
Copy link
Contributor Author

@rameshkumarchandra Can you please have a look at this small PR? Thanks!

@asquelt
Copy link

asquelt commented Jan 7, 2024

domain part may contain multiple segments. ie. mycorp.co.uk or mail.tla.gov.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants