-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Postgres version update and minio client image add in values file #45
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -36,7 +36,7 @@ redis: | |
|
||
postgres: | ||
local_setup: true | ||
image: postgres:15.5-alpine | ||
image: postgres:15.7-alpine | ||
servicePort: 5432 | ||
cliConnectPort: "" | ||
storageClass: longhorn | ||
|
@@ -59,6 +59,7 @@ rabbitmq: | |
|
||
minio: | ||
image: minio/minio:latest | ||
image_mc: minio/mc:latest | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 💡 Codebase verification 🛠️ Refactor suggestion Use a specific version tag for the MinIO Client image instead of The Recommended Change: image_mc: minio/mc:RELEASE.2023-05-04T18-10-16Z You can find the latest stable version on the MinIO Client Docker Hub page. 🔗 Analysis chainConsider using a specific version tag for the MinIO Client image. While adding the MinIO Client image is beneficial for managing MinIO deployments, using the Consider replacing the image_mc: minio/mc:RELEASE.2023-05-04T18-10-16Z You can find the latest stable version on the MinIO Client Docker Hub page. Additionally, to ensure the MinIO Client is properly configured, you may want to add the following verification step: This will output the MinIO Client pod configuration from the rendered template, allowing you to verify that the image and any associated settings are correct. 🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Verify MinIO Client configuration
helm template . | grep -A 5 "name: minio-client"
Length of output: 122 Script: #!/bin/bash
# Check the image_mc value in charts/plane-ce/values.yaml
grep 'image_mc:' charts/plane-ce/values.yaml
Length of output: 72 |
||
local_setup: true | ||
pullPolicy: IfNotPresent | ||
root_password: password | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codebase verification
Hardcoded PostgreSQL 15.5 references found in multiple files.
The shell script identified several hardcoded references to
postgres:15.5-alpine
in the following files:charts/plane-enterprise/questions.yml
charts/plane-enterprise/README.md
charts/plane-ce/questions.yml
charts/plane-ce/README.md
These references should be updated to
postgres:15.7-alpine
to maintain consistency and ensure that all components use the updated PostgreSQL version.🔗 Analysis chain
Approve PostgreSQL version update with verification recommendation.
The update of the PostgreSQL image from version 15.5-alpine to 15.7-alpine is a good practice for maintaining security and stability. However, it's important to ensure compatibility with the rest of the system.
Please verify the following:
To help with verification, you can run the following script to check for any hardcoded references to the old PostgreSQL version:
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
Length of output: 726