100 - CSV Download of gradebook #250
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xes to update page, edit form, etc
NicholasMy
requested changes
Apr 16, 2025
Comment on lines
+14
to
+16
| let updatedTime = new Date(date) | ||
| updatedTime.setHours(updatedTime.getHours() + 4) // jank fix, but makes due dates appear correctly :D | ||
| return updatedTime.toLocaleString('en-us', { |
There was a problem hiding this comment.
As we discussed, this needs to be updated to display the time to the local timezone. The database should store everything in UTC time, and the browser should display it in the local timezone.
Comment on lines
+115
to
+120
| const link = document.createElement("a"); | ||
| link.setAttribute("href", encodedUri); | ||
| link.setAttribute("download", `${courseName.replace(" ", '').toLowerCase() ?? 'class'}_gradebook`); | ||
| document.body.appendChild(link); | ||
| link.click(); | ||
| document.body.removeChild(link); |
There was a problem hiding this comment.
This might be okay for now, but there must be a better way to do this than temporarily creating a link and simulating it being clicked.
Comment on lines
+207
to
+212
| const link = document.createElement("a"); | ||
| link.setAttribute("href", encodedUri); | ||
| link.setAttribute("download", `${course?.number.replace(" ", '').toLowerCase() ?? 'class'}_gradebook`); | ||
| document.body.appendChild(link); | ||
| link.click(); | ||
| document.body.removeChild(link); |
There was a problem hiding this comment.
There's a lot of duplicate code here (from the student gradebook page). It would be good to abstract common logic out to a utility function.
| @@ -68,7 +68,7 @@ const TextProblemModal = ({ open, onClose }: Props) => { | |||
| await RequestService.post(`/api/course/${courseId}/assignment/${assignmentId}/non-container-auto-graders/`, graderFormData) | |||
| .then(() => { | |||
| console.log("GRADER CREATED") | |||
| window.location.reload() | |||
| //window.location.reload() | |||
| @@ -277,19 +276,18 @@ const AssignmentDetailPage = () => { | |||
| </div> | |||
| </div> | |||
|
|
|||
|
|
|||
|
|
|||
| {submissions.length != 0 && | |||
There was a problem hiding this comment.
Suggested change
| {submissions.length != 0 && | |
| {submissions.length !== 0 && |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for downloading gradebooks to csv files, and fixed some text field styling in various places across the site, made submissions clickable from anywhere on the card, updated due date printing to show time correctly.
Proposed changes
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.
If it fixes a bug or resolves a feature request, be sure to link to that issue using #{issue_number}.
Types of changes
What types of changes does your code introduce?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any ofthem, don't hesitate to ask. This is simply a reminder of what we are going to look for before merging your code.