fix: dynamic coverage command

makeomatic · Oct 21, 2018 · d675501 · d675501
1 parent 3dcda50
commit d675501
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/bin/cmds/test.js b/bin/cmds/test.js
@@ -78,8 +78,9 @@ exports.builder = yargs => (
     })
     .option('coverage', {
       describe: 'whether to upload coverage or not',
-      boolean: true,
-      default: !!process.env.CI,
+      default: process.env.CI === 'true'
+        ? './node_modules/.bin/codecov'
+        : false,
     })
     .option('root', {
       describe: 'binary root path on the tester',

diff --git a/bin/cmds/test_cmds/run.js b/bin/cmds/test_cmds/run.js
@@ -102,6 +102,6 @@ exports.handler = async (argv) => {
   // upload codecoverage report
   if (argv.coverage) {
     // this is to avoid exposing token
-    await echoAndExec('./node_modules/.bin/codecov > /dev/null &2>1');
+    await echoAndExec(`${argv.coverage} > /dev/null 2>1`);
   }
 };