GRC price update #59
Merged
GRC price update #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for writing this! It looks like the tests are failing on the new function, can you please fix? I'm happy to include these improvements :) |
…nction into retriever and parser. Adds soups for testing.
|
I made some updates to the tests. Let me know if they are sufficient or if I need to make improvements. |
|
I'm honestly not sure what to do here. I can't replicate this locally and the path looks to be correct. |
|
Never mind. I think I figured it out. The tests use python 3.8 and I was using python 3.9 type hints. |
|
Merged, thank you for contributing to FTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current price fetching method with coingecko and yahoo does not work because of various website updates. This pull request uses sites that have the info scrapeable and also accessable by regex or beautifulsoup. I used beautifulsoup because it was easier to find the price and scrape it that way.