-
Notifications
You must be signed in to change notification settings - Fork 620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Kogan air purifier 5 pro #2889
Add support for Kogan air purifier 5 pro #2889
Conversation
Based on fisher_summer Adds support for: - Anti-frost - Anti-mildew - Buzzer on/off - Display on/off - Eco mode on/off - Health (UV and Ioniser) - Self cleaning Fixes - Horizontal fixed position, not supported according to bitfield but it is and works - Removed "Power" setting (1kWh/2kWh etc.), which does nothing - Removed Running time, as it always reports 1s - Added appropriate icons - Removed "wide" swing modes (not supported) - Removed Hot cold wind - Removed Generator mode - Removed Energy saving Caveats - Customised for this specific model/id, so optional DPS removed (avoids unavailable entities, which aren't disabled by default) - Air quality & Dirty filter probably aren't supported (they just report Great and OK), so they're in diagnostic
Based on lifubide_x600_purifier (closest match) Added support for: - Air quality - Filter remaining - Filter time - Timer remaining - Fan speed - Filter reset - Off timer - Preset mode (Smart/Sleep/Manual) - UV sterilization
Fixed unit in wrong place
Query Properties for this device: { |
name: sensor | ||
unit: ugm3 | ||
class: measurement | ||
- name: Preset mode |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no need to duplicate this
category: config | ||
icon: "mdi:fan" | ||
dps: | ||
- id: 4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could be merged into the fan entity as speed (percentage)
name: sensor | ||
type: integer | ||
unit: "%" | ||
- name: Child lock |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The standard pattern for child locks is to use a lock entity, with translation_key: child_lock.
- translation_key: filter_reset | ||
entity: button | ||
category: config | ||
icon: "mdi:clock-outline" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There should be no need to override icons for translated entities.
type: boolean | ||
name: button | ||
optional: true | ||
- name: Timer remaining |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
translation_key: time_remaining
type: string | ||
mapping: | ||
- dps_val: great | ||
value: Great |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
air_quality sensors should use values from the translated keys: "excellent", "good", "moderate", "poor", "severe"
type: integer | ||
unit: h | ||
mapping: | ||
- scale: 3600 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it has class: duration, there should be no need to scale it. Scaling should be automatic.
unit: h | ||
mapping: | ||
- scale: 3600 | ||
- name: Off timer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
translation_key: timer
is probably better. And class: duration
should be used.
- id: 102 | ||
type: integer | ||
name: value | ||
unit: m |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unit should not be metres. Maybe "min", but "h" seems more likely to me, as a 12 minute off timer seems very short.
- changes proposed in PR make-all#2889 - standardise filename as manufacturer_model_type.yaml - remove meaningless "Smart" from device name
- add model info for existing Kogan air purifier to better differentiate
Based on lifubide_x600_purifier (closest match)
Added support for: