Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scripts to install dev tools manually #14

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

boekhorstb1
Copy link
Contributor

@boekhorstb1 boekhorstb1 commented Sep 22, 2022

I find this practical because the container setup sometimes takes to long to install all the needed dev tools.
With manual scripts one can start working and let the scripts to install all thats needed.

  • also usefull so one can isntall devtools when the container itself needs debugging and devtoosl cannot be isntalled from entrypoint.sh

@ralflang ralflang self-requested a review September 27, 2022 07:12
@ralflang
Copy link
Contributor

That's two different things.

  • Factoring out the scripts that install development tools for reuse. Everything that moves implementation detail into separate files and only keeps an (if file exists run file: foo.sh) block in the entrypoint is good.

  • How to run the development script. At the moment we have a switch for development mode that does two things: autoloader config for either production optimized or development optimized. Install some default extra packages. And we have an additional variable that allows to install extra software. We should not make it too complicated.
    If the user wants the production setup and sets variable to no, he can still install the development tools later.
    If the user wants the development setup and sets the variable to yes, he should get that. If waiting for development tools is too long, running the install script in the background (with &) may be the solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants