fix: correct github commit after link in commit list #2000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XS
meteyou
approved these changes
Sep 8, 2024
|
thx for fixing this bug! |
|
No problem! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes an incorrect GitHub URL when the Moonraker
update_managerextension name does not match the GitHub repo name.Given the following update manager extension config (which is the one LED Effects for Klipper uses)
[update_manager led_effect] type: git_repo path: ~/klipper-led_effect origin: https://github.com/julianschill/klipper-led_effect.git is_system_service: FalseThe change corrects the "Link to GitHub" buttton's address from
https://github.com/julianschill/led_effect/commits/master/?after=bde44b49246a0fe7b50d41e415d71e8f966d9542+0
to
https://github.com/julianschill/klipper-led_effect/commits/master/?after=bde44b49246a0fe7b50d41e415d71e8f966d9542+0
Related Tickets & Documents
none
Mobile & Desktop Screenshots/Recordings
none
[optional] Are there any post-deployment tasks we need to perform?
none