Remove Glimmer AST Deprecation #1220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ohhhh, so that's where these messages are coming from :D looks like we have to fix CI first though 🙈 |
Accessing this value in original is deprecated, and very noisily so, replacing this with value as recommended.
Turbo87
force-pushed
the
glimmer-deprecations
branch
from
4bf8559 to
5660eaf
Compare
|
I've gotten good at tracking them down in the last couple of weeks, you need a debugger and a magnifying glass 😁. Thanks for the quick release! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accessing this value in original is deprecated, and very noisily so, replacing this with value as recommended.
Deprecation Message:
DEPRECATION: The original property on literal nodes is deprecated, use value insteadFixes #1219