Wrap errors raised by Process.spawn in a ProcessExecuter::SpawnError #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR ensures that any exception raised by Process.spawn is wrapped in a ProcessExecuter::SpawnError so that client code can uniformly handle errors.
- Introduced a new exception type, SpawnError, in the error hierarchy.
- Updated methods to rescue and wrap exceptions from Process.spawn.
- Added tests and documentation updates to reflect the new error behavior.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| spec/process_executer_spawn_and_wait_spec.rb | Added test verifying that an invalid command raises a SpawnError. |
| lib/process_executer/runner.rb | Updated documentation to consolidate error types into ProcessExecuter::Error. |
| lib/process_executer/errors.rb | Added SpawnError to the error hierarchy and updated error documentation. |
| lib/process_executer.rb | Wrapped Process.spawn in a rescue block to raise SpawnError. |
| README.md | Updated information to note that SpawnError is not suppressed by raise_errors. |
…awnError` The errors raised by `Process.spawn` for each error condition are inconsistent between different Ruby engines. This change wraps any exception raised by `Process.spawn` in a `ProcessExecuter::SpawnError` so that client code can more easily deal with these problems. The actual error raised by `Process.spawn` is accessible from the `#cause` method. `SpawnError`s are not suppressed by the `raise_errors: false` option.
jcouball
changed the title
Process.spawn in a ProcessExecuter::SpawnError error
|
Code Climate has analyzed commit d953359 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (100% is the threshold). This pull request will bring the total coverage in the repository to 100.0% (0.0% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The errors raised by
Process.spawnfor each error condition are inconsistent between different Ruby engines. This change wraps any exception raised byProcess.spawnin aProcessExecuter::SpawnErrorso that client code can more easily deal with these problems.The actual error raised by
Process.spawnis accessible from the#causemethod.SpawnErrors are not suppressed by theraise_errors: falseoption.