Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use version type rather than strings #24

Merged
merged 1 commit into from
Mar 21, 2024

Commits on Mar 20, 2024

  1. refactor: use version type rather than strings

    Upgrade to `sn-releases` version 0.2.0, which forces the use of the `semver::Version` type rather
    than `String` for dealing with versions.
    
    It made sense to do the same thing with string-based version fields in this crate. All of the fields
    on the `Settings` type were also turned into an `Option`, which makes sense because it's possible
    that we don't have one of the asset types installed. I'm not sure why this wasn't done in the first
    place. It made the code a bit simpler.
    
    BREAKING CHANGE: settings files from previous versions will not deserialize properly and will have
    to be deleted.
    jacderida committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    9525258 View commit details
    Browse the repository at this point in the history