bugfix: fix edge cases related to time atomicity #123
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These changes aim to make it so that calls to the public API operate over the cache using a single Instant of time rather than calling Instant::now() at several unique points in time during the synchronous execution of the function. The former execution model lead to potential bugs, notably in functions like entry() as brought up in maidsafe#122, especially on targets with less processing power or under heavy load. This also reduces the number of system calls that need to be made which may improve performance for some use cases. Signed-off-by: Paul Osborne <[email protected]>
Under a heavy CPU load, time can elapse between insert/get_mut on an entry which results in a panic. Signed-off-by: Paul Osborne <[email protected]>
|
@ustulation Can I get a review on this; it should be noted that the cache implementation is fundamentally broken without some change. |
|
I'm a user of the lru_time_cache library and I would like to see this bug fixed. I chose the lru_time_cache library due to its lack of unsound unsafe code. There's not that many lru caches in rust. Thank you for providing and maintaining it! I hope it's not rude to ping this issue after 3 months :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes aim to make it so that calls to the public API
operate over the cache using a single Instant of time rather than
calling Instant::now() at several unique points in time during the
synchronous execution of the function.
The former execution model lead to potential bugs, notably in functions
like entry() as brought up in #122, especially on targets with less processing
power or under heavy load.
This also reduces the number of system calls that need to be made which
may improve performance for some use cases.