Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imp -> importlib in setup.py #263

Merged
merged 2 commits into from
Aug 23, 2023
Merged

imp -> importlib in setup.py #263

merged 2 commits into from
Aug 23, 2023

Conversation

kurtbrose
Copy link
Collaborator

written but not tested yet

@kurtbrose
Copy link
Collaborator Author

lol oops that didn't work

@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Merging #263 (78a70e3) into master (3431501) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #263   +/-   ##
=======================================
  Coverage   98.01%   98.01%           
=======================================
  Files          27       27           
  Lines        4335     4335           
  Branches      748      748           
=======================================
  Hits         4249     4249           
  Misses         56       56           
  Partials       30       30           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Owner

@mahmoud mahmoud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, needed to rebase to fix CI, but tests ok there, and locally.

@mahmoud mahmoud merged commit 1f883f0 into master Aug 23, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants