Job stats server enhancements #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Include all possible job props to DB to render them in dashboard * Use model.Duration from prometheus/common for CLI args that need time duration. More user friendly * Ensure that we do not duplicate entries in DB using INSERT or REPLACE. This enables us to query for running jobs as well in future if necessary * Create a unique index on jobid and start time * Minor formatting updates Signed-off-by: Mahendra Paipuri <[email protected]>
* Add admin-users CLI arg. Admin users can impersonate users by querying for different user set in specific header * Add ability to query for a single job based on jobid and/or jobuuid * Pass entire DB config to server * Limit query window to 3 months to prevent making big queries * Add new test scenarios for testing different end points * Update test fixtures and Makefile Signed-off-by: Mahendra Paipuri <[email protected]>
* The current logic might end up in a situation where vacuuming will never be triggered * Use only constraint of hour of vacuuming along with vacuum interval of 1 week Signed-off-by: Mahendra Paipuri <[email protected]>
Signed-off-by: Mahendra Paipuri <[email protected]>
Signed-off-by: Mahendra Paipuri <[email protected]>
Signed-off-by: Mahendra Paipuri <[email protected]>
Signed-off-by: Mahendra Paipuri <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BatchJobstruct now includes more job propertiesstats_serverto set admin users