Fix prototypes bug in fabrics

mahabra · Mar 1, 2015 · 2df1a03 · 2df1a03
1 parent 34d763d
commit 2df1a03
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 8 deletions.
diff --git a/.dvlp/scripts/brahma/internals/module.internals.js b/.dvlp/scripts/brahma/internals/module.internals.js
@@ -46,11 +46,9 @@
 						if ("function"==typeof Brahma.classes.module.internals[internals[i]].initial) Brahma.classes.module.internals[internals[i]].initial.call(module);
 					}
 				}
-				Brahma.extend(constructor.prototype, options);
-				constructor.prototype.master = this;
-				constructor.prototype.constructor = constructor;
 
 				var module = new constructor();
+				Brahma.extend(module, options);
 				module.master = this;
 
 				return module;

diff --git a/bower.json b/bower.json
@@ -1,6 +1,6 @@
 {
   "name": "brahma",
-  "version": "1.3.3",
+  "version": "1.3.4",
   "authors": [
     "Morulus <[email protected]>"
   ],

diff --git a/dist/brahma.js b/dist/brahma.js
@@ -413,11 +413,9 @@ Brahma.die= function(a) {
 						if ("function"==typeof Brahma.classes.module.internals[internals[i]].initial) Brahma.classes.module.internals[internals[i]].initial.call(module);
 					}
 				}
-				Brahma.extend(constructor.prototype, options);
-				constructor.prototype.master = this;
-				constructor.prototype.constructor = constructor;
 
 				var module = new constructor();
+				Brahma.extend(module, options);
 				module.master = this;
 
 				return module;

diff --git a/test/index.html b/test/index.html
@@ -110,6 +110,16 @@ <h2>Hi</h2>
 			assert.equal(window.testready, true, "DOM ready!");
 			start();
 		});
-	})
+	});
+
+	QUnit.test("test modules", function( assert ) {
+		var app1 = Brahma.app('test1', {
+			a: 123
+		});
+		var app2 = Brahma.app('test2', {
+			a: 456
+		});
+		assert.equal(app2.a+app1.a, 579, "prototypes different");
+	});
 </script>
 </html>