Run tests on BSDs, too. #86
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that FreeBSD support has been added to readchar/key.py, these tests run just fine.
Closed
|
Thank you for this PR. I also thought about this, but if this gets incorporated we would also have to extend the CI test-workflow. And than comes the question, why only BSD? Why not MacOS also? And others? This gets more complicated than I am willing to handle and also would require somebody to handle isses that come up from this. This is also why the testfolder is still named Linux and not Posix like the sourcefiles. Tests are only provided / supported for Linux and Windows and more is not actively maintained. Everyone is of course free to remove the guard-staments and run the tests on this own risks. |
Cube707
added
wontfix
Repository owner
locked as resolved and limited conversation to collaborators
Nov 9, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that FreeBSD support has been added to readchar/key.py, these tests run just fine.