-
Notifications
You must be signed in to change notification settings - Fork 3
Pre-1.9 merge of magma-deployer #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
different magma-deployer version than the magma/magma-deployer main branch (e.g., a fork)
nginx_proxy_ssl.conf template
JITCloudlet Magma_recipe as agw-deployer
deploy-orc8r.sh; delete bootstrap version in favor of prompt.
lucasgonze
approved these changes
Apr 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Numerous substantial improvements in a valuable project that is not mission critical - no brainer. I'm approving without reading or running the code, for the sake of clearing bureaucracy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Magma-deployer was created at 1.8 to deploy containerized AGWs. The main branch has not been updated since then. This PR pulls in pre-1.9 revisions developed for the 5G deployment at Carnegie Mellon University. It restructures the deployer to include both AGW and Orc8r deployment and updates the AGW deployer for pre-1.9 deployments. Also, includes a number of clean up items.
This PR brings the main branch up to a level that worked at pre-release levels of 1.9. It will need to be updated to get it to the release 1.9 release level. The primary updates will need to be around the artifact (e.g., container) retrievals from jfrog with the new names and keys.
Test Plan
This PR was tested for both AGW and Orc8r during the 5G deployment at CMU. It worked for that specific deployment but may have some environment specific issues. See this article.
Additional Information
This change is backwards breaking.
It will need additional updates for production level 1.9.