Updated Readme to include more complete instructions on running S1AP tester #38
Conversation
facebook-github-bot
added
the
CLA Signed
| ``` | ||
| On successful compilation, the “libtfw.so” library gets generated under | ||
| TestCntlrApp/lib folder. | ||
| TestCntlrApp/lib folder which is copied to ``/usr/lib``. |
There was a problem hiding this comment.
which is copied to => which needs to be / should be copied to
The copying of .so file does not happen automatically as part of compilation and needs to be done separately as shown in steps.
There was a problem hiding this comment.
@VinashakAnkitAman Referring line number 56, libtfw.so is getting copied to /usr/lib
So sentence in line number 60 looks to be fine
There was a problem hiding this comment.
@VinashakAnkitAman Referring line number 56, libtfw.so is getting copied to /usr/lib
So sentence in line number 60 looks to be fine
| @@ -53,18 +53,55 @@ S1APTester binary can be generated by executing below compilation steps: | |||
| $ cd TestCntlrApp/build | |||
| $ make cleanall | |||
| $ make | |||
| $ sudo cp ../lib/libtfw.so /usr/lib | |||
| $ cd ../../ | |||
There was a problem hiding this comment.
This statement is not needed here: cd ../../
There was a problem hiding this comment.
Instead of cd ../../, specify the path from the folder created from "git clone "
If get code by command "https://github.com/facebookexperimental/S1APTester.git" S1APTester is folder created. You can specify path from S1APTester
|
|
||
| ## Compile Traffic Generator | ||
| ``` | ||
| $ cd Trfgen/build | ||
| $ make clean | ||
| $ make | ||
| $ sudo cp ../lib/libtrfgen.so /usr/lib | ||
| $ cd ../../ |
There was a problem hiding this comment.
This statement is not needed here: cd ../../
| ``` | ||
| On successful compilation, the “libtrfgen.so” library gets generated under | ||
| Trfgen/lib folder. | ||
| Trfgen/lib folder which is copied to ``/usr/lib``. |
There was a problem hiding this comment.
which is copied to => which needs to be / should be copied to
The copying of so file does not happen automatically as part of compilation and needs to be done separately as shown in steps.
| $ cd TestCntlrStub/build | ||
| $ make clean | ||
| $ make | ||
| $ cd ../bin/ |
There was a problem hiding this comment.
This statement is not needed here in the steps: cd ../bin/
| $ sudo ./testCntrlr -f testCaseList_1.txt | ||
| ``` | ||
|
|
||
| Log messages will be shown on screen and in the text file ``log`` created in the same directory. |
| ``` | ||
| On successful compilation, the “libtfw.so” library gets generated under | ||
| TestCntlrApp/lib folder. | ||
| TestCntlrApp/lib folder which is copied to ``/usr/lib``. |
There was a problem hiding this comment.
@VinashakAnkitAman Referring line number 56, libtfw.so is getting copied to /usr/lib
So sentence in line number 60 looks to be fine
| ``` | ||
| On successful compilation, the “libtfw.so” library gets generated under | ||
| TestCntlrApp/lib folder. | ||
| TestCntlrApp/lib folder which is copied to ``/usr/lib``. |
There was a problem hiding this comment.
@VinashakAnkitAman Referring line number 56, libtfw.so is getting copied to /usr/lib
So sentence in line number 60 looks to be fine
| @@ -53,18 +53,55 @@ S1APTester binary can be generated by executing below compilation steps: | |||
| $ cd TestCntlrApp/build | |||
| $ make cleanall | |||
| $ make | |||
| $ sudo cp ../lib/libtfw.so /usr/lib | |||
| $ cd ../../ | |||
There was a problem hiding this comment.
When we compile S1ap tester code within magma_test VM, generated library libtfw.so is copied to path "/home/vagrant/s1ap-tester/bin".
Even I didn't locate libtfw.so file in path /usr/lib/
So in what context libtfw.so is copied to /usr/lib/?
There was a problem hiding this comment.
In case of using S1APTester with normal magma setup, the steps of copying the libtfw.so file to /home/vagrant/s1ap-tester/bin/ is part of VM provisioning and the python scripts are importing directly from this path.
As of now, the stub binary "testCntrlr" is trying to search the libtfw.so file in default lib folders as the path is not specified with the binary. This is why we need to copy the .so file in /usr/lib/ folder.
| @@ -53,18 +53,55 @@ S1APTester binary can be generated by executing below compilation steps: | |||
| $ cd TestCntlrApp/build | |||
| $ make cleanall | |||
| $ make | |||
| $ sudo cp ../lib/libtfw.so /usr/lib | |||
| $ cd ../../ | |||
There was a problem hiding this comment.
When we compile S1ap tester code within magma_test VM, generated library libtfw.so is copied to path "/home/vagrant/s1ap-tester/bin".
Even I didn't locate libtfw.so file in path /usr/lib/
So in what context libtfw.so is copied to /usr/lib/?
| @@ -53,18 +53,55 @@ S1APTester binary can be generated by executing below compilation steps: | |||
| $ cd TestCntlrApp/build | |||
| $ make cleanall | |||
| $ make | |||
| $ sudo cp ../lib/libtfw.so /usr/lib | |||
| $ cd ../../ | |||
There was a problem hiding this comment.
Instead of cd ../../, specify the path from the folder created from "git clone "
If get code by command "https://github.com/facebookexperimental/S1APTester.git" S1APTester is folder created. You can specify path from S1APTester
|
Bump. This is a useful change to get landed. |
Title
Updated Readme to include more complete instructions on running S1AP tester
Summary
Updated the Readme file to include more information on compiling and running the code standalone. (ie as not part of the Magma test Suite and with other EPCs)
Test plan
No code changes, but copy-paste tested examples to confirm they work.
(Some issues compiling on current master but will opened separate PR for that with fix)