Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/breadcrumb #65

Merged
merged 1 commit into from
Mar 5, 2018
Merged

Feature/breadcrumb #65

merged 1 commit into from
Mar 5, 2018

Conversation

IsmaelVillavicencio
Copy link

link : #29
Originals
desktop 1280
mobile portrait

How it looks
desktop
mobile

});

document.getElementById('CloseMenu').addEventListener('click', function() {
document.getElementById("logo").className = 'whiteLogo';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mixed double and single quotes.

# Per-page layout changes
page '/*.xml', layout: false
page '/*.json', layout: false
page '/*.txt', layout: false

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.


# Per-page layout changes
page '/*.xml', layout: false
page '/*.json', layout: false

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

# https://middlemanapp.com/basics/layouts/

# Per-page layout changes
page '/*.xml', layout: false

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

@IsmaelVillavicencio IsmaelVillavicencio changed the base branch from master to MH-theme5 March 3, 2018 00:54
Copy link
Contributor

@albertm805 albertm805 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@IsmaelVillavicencio IsmaelVillavicencio merged commit 0e802ee into MH-theme5 Mar 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants