Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme 1 #4

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Theme 1 #4

wants to merge 9 commits into from

Conversation

diegosaul402
Copy link

@diegosaul402 diegosaul402 commented Jan 27, 2018

Implements - WIP

This implements this theme design to a shopify theme using Slate.
https://www.dropbox.com/sh/l4ltmmel0h0tlam/AABuXCfinzzQsqIBw2YtbxZ-a/Theme%201?dl=0



/*================ Responsive Text Alignment Helper ================*/
@mixin responsive-text-align-helper($breakpoint: '') {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer double-quoted strings

}

/*================ Responsive Show/Hide Helper ================*/
@mixin responsive-display-helper($breakpoint: '') {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer double-quoted strings

}

// sass-lint:disable
*zoom: 1;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unknown property *zoom

/*================ Mixins ================*/
@mixin clearfix() {
&::after {
content: '';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Properties should be ordered clear, content, display
Prefer double-quoted strings


@mixin visually-shown($position: inherit) {
// sass-lint:disable no-important
position: $position !important;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

!important should not be used


@mixin visually-hidden() {
// sass-lint:disable no-important
position: absolute !important;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

!important should not be used

}

.#{$breakpoint}text-center {
text-align: center !important;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

!important should not be used

}

.#{$breakpoint}text-right {
text-align: right !important;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

!important should not be used

@mixin responsive-text-align-helper($breakpoint: '') {
// sass-lint:disable no-important
.#{$breakpoint}text-left {
text-align: left !important;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

!important should not be used

}

.#{$breakpoint}hide {
display: none !important;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

!important should not be used

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants