-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Theme 1 #4
base: master
Are you sure you want to change the base?
Theme 1 #4
Conversation
|
||
|
||
/*================ Responsive Text Alignment Helper ================*/ | ||
@mixin responsive-text-align-helper($breakpoint: '') { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prefer double-quoted strings
} | ||
|
||
/*================ Responsive Show/Hide Helper ================*/ | ||
@mixin responsive-display-helper($breakpoint: '') { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prefer double-quoted strings
} | ||
|
||
// sass-lint:disable | ||
*zoom: 1; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unknown property *zoom
/*================ Mixins ================*/ | ||
@mixin clearfix() { | ||
&::after { | ||
content: ''; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Properties should be ordered clear, content, display
Prefer double-quoted strings
|
||
@mixin visually-shown($position: inherit) { | ||
// sass-lint:disable no-important | ||
position: $position !important; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
!important should not be used
|
||
@mixin visually-hidden() { | ||
// sass-lint:disable no-important | ||
position: absolute !important; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
!important should not be used
} | ||
|
||
.#{$breakpoint}text-center { | ||
text-align: center !important; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
!important should not be used
} | ||
|
||
.#{$breakpoint}text-right { | ||
text-align: right !important; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
!important should not be used
@mixin responsive-text-align-helper($breakpoint: '') { | ||
// sass-lint:disable no-important | ||
.#{$breakpoint}text-left { | ||
text-align: left !important; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
!important should not be used
} | ||
|
||
.#{$breakpoint}hide { | ||
display: none !important; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
!important should not be used
Implements - WIP
This implements this theme design to a shopify theme using Slate.
https://www.dropbox.com/sh/l4ltmmel0h0tlam/AABuXCfinzzQsqIBw2YtbxZ-a/Theme%201?dl=0