Allow nikic/php-parser ^5.0.0 #545
Conversation
|
This patch can only be merged if CI also runs the newest dependencies: "allowing" them is insufficient, and #484 highlights the associated failures |
|
Okay, in this case I'll update the MR in the next release of |
| datasource | package | from | to | | ---------- | --------------- | ------- | ------- | | packagist | phpunit/phpunit | 10.5.30 | 10.5.31 |
| datasource | package | from | to | | ---------- | --------------- | ------ | ------ | | packagist | phpstan/phpstan | 1.12.0 | 1.12.1 |
| datasource | package | from | to | | ---------- | --------------- | ------- | ------- | | packagist | phpunit/phpunit | 10.5.31 | 10.5.32 |
| datasource | package | from | to | | ---------- | --------------- | ------ | ------ | | packagist | phpstan/phpstan | 1.12.1 | 1.12.2 |
| datasource | package | from | to | | ---------- | ----------- | ------ | ------ | | packagist | vimeo/psalm | 5.25.0 | 5.26.0 |
| datasource | package | from | to | | ---------- | --------------- | ------- | ------- | | packagist | phpstan/phpstan | 1.12.2 | 1.12.3 | | packagist | phpunit/phpunit | 10.5.32 | 10.5.33 |
| datasource | package | from | to | | ---------- | ----------- | ------ | ------ | | packagist | vimeo/psalm | 5.26.0 | 5.26.1 |
| datasource | package | from | to | | ---------- | --------------- | ------- | ------- | | packagist | phpunit/phpunit | 10.5.33 | 10.5.34 |
gazben
force-pushed
the
fix/upgrade-php-parser
branch
from
39f5eca to
c1b254b
Compare
|
Diff no longer contains |
|
I thought that with the new release of Sorry for the confusion |
|
According to vimeo/psalm#11112 (comment), |
|
Psalm 6 released. Is there anything else beed for nikic/php-parser 5 support? |
|
The problem is the |
|
Thanks, updated with the new release. |
|
Sounds like the parser did indeed break a lot here. This run shows a ton of broken property access issues: https://github.com/maglnet/ComposerRequireChecker/actions/runs/12984968315/job/36209988057?pr=545 |
Ocramius
added
duplicate
enhancement
dependencies
|
Sorry I din't have time to port it. I hope I can try out the new version |
|
@gazben it's fine, it's merged + released :-) |
The
nikic/php-parserpackage is now upgraded to 5.0. According to the changelog, this version drops the php 5 parsing and requires php 7.4.There is automated MR regarding this topic: #484
But that MR takes a more radical approach by not allowing the v4 version.
Changelog: https://github.com/nikic/PHP-Parser/releases/tag/v5.0.0