Support not using bug-reference-mode in remote files
#703
Conversation
What part is expensive? Did you do some benchmarking? I don't think it is "unnecessary" in the same way as was the case for magit/magit#5222. This does cause bug-references to be by "linkified", doesn't it? Doing that might be too expensive to be worth it, but "unnecessary" doesn't seem like the appropriate term, unless I am missing something. Can you say more about the hanging? Why does that happen? Does that actually happen, or is the process just so slow, that you always abort before it completes? |
|
Thanks for checking this PR! For a given remote file, it basically hangs for at least a minute, before I manually abort. Then, if I try to open the same file again, it opens immediately. When trying a different file, the second try would work again. Neither of these files are inside a git repository, just a regular folder where I have read/write access. When invoking tramp to access those files, I'm also not inside any local git repository. As such, it seems unnecessary for forge to jump in. Earlier today, I made a screenshot of the stack trace after sending a SIGUSR2 to emacs while it was hanging, see attached. That's where I noticed
|
bramadams
force-pushed
the
tramp-speedup
branch
from
fa1c725 to
53ff38e
Compare
|
@tarsius Just a heads-up that I've rebased the PR up to forge 0.4.5. I can confirm that the PR has been working perfectly for the past 3 months (no more hangs), both on 29.x and the latest 30.x pretest. Is it possible to merge this? |
tarsius
changed the title
auto-revert-remote-files in forge-bug-reference-setupbug-reference-mode in remote files
This is done for performance reasons, see magit#703. Because the maintainer is not entirely convinced this is necessary, this is a regular variable instead of a user option for now.
tarsius
force-pushed
the
tramp-speedup
branch
from
53ff38e to
8bace81
Compare
|
Happy new year! |
|
Thanks a lot, and happy holidays to you too! |
Fixes a similar issue as magit/magit#5222, where, when using tramp, forge would do substantial unnecessary work inside
forge-bug-reference-setup, slowing down the connection or even hanging.To fix this issue, changes similar to the original magit commit (see magit/magit@61c051e) could easily be repeated, basically shortening out the
unlesswithinforge-bug-reference-setup.