Fix for usage responses missing more data than intended #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etries. Caller can change settings or disable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also ran formatter, so that makes this a little harder to follow. Should be easier to follow PRs afterward, or just look at individual commits.
Main changes are in pyemvue.py and
get_device_list_usagearound line 150 (in the new side). That function now allows passing the retry parameters in case you don't want to use them or want different amounts, likely need to do something similar for the retries withinauth.py.Main bugfix in that function is to continue iterating over the whole set of data and not quitting immediately. That could result in missing data for anyone but is most obvious when there are two root devices and one is offline, if the offline device is first in the list then we will never get data for the second device. Sometimes the order changes but not consistently.