Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: unable to scroll on ios safari #851

Merged
merged 8 commits into from
Feb 3, 2025
Merged

fix: unable to scroll on ios safari #851

merged 8 commits into from
Feb 3, 2025

Conversation

joshuascan
Copy link
Member

@joshuascan joshuascan commented Jan 30, 2025 •
edited
Loading

📦 Pull Request

This fixes scrolling being broken on iOS Safari on iOS version 17 and earlier. Reverting to display: none was not a feasible solution as it breaks part of our analytics.

✅ Fixed Issues

🚨 Test instructions

[Describe any additional context required to test the PR/feature/bug fix.]

⚠️ Don't forget to add a semver label!

Please 🚨 ONLY ADD ONE 🚨 of the following labels, failing to do so may lead to adverse versioning of your changes when published:

  • patch: Bug Fix?
  • minor: New Feature?
  • major: Breaking Change?
  • skip-release: It's unnecessary to publish this change.

Special Note

Please avoid adding any of the Priority labels as they conflict with the labels above ☝️

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @magic-sdk/[email protected]
npm install [email protected]
# or 
yarn add @magic-sdk/[email protected]
yarn add [email protected]

@joshuascan joshuascan added the patch Increment the patch version when merged label Jan 31, 2025
@joshuascan joshuascan changed the title Pdeexp 2252 unable to scroll on ios safari fix: unable to scroll on ios safari Jan 31, 2025
@joshuascan joshuascan marked this pull request as ready for review January 31, 2025 21:55
@joshuascan joshuascan requested a review from a team as a code owner January 31, 2025 21:55
@joshuascan joshuascan self-assigned this Jan 31, 2025
@joshuascan joshuascan requested a review from Ethella February 3, 2025 17:03
@joshuascan joshuascan added this pull request to the merge queue Feb 3, 2025
Merged via the queue into master with commit 3db0b8a Feb 3, 2025
6 checks passed
@joshuascan joshuascan deleted the PDEEXP-2252-unable-to-scroll-on-i-os-safari branch February 3, 2025 17:19
@Ethella
Copy link
Member

Ethella commented Feb 3, 2025

🚀 PR was released in @magic-sdk/[email protected], [email protected] 🚀

@Ethella Ethella added the released This issue/pull request has been released. label Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ethella Ethella Ethella approved these changes

Assignees

@joshuascan joshuascan

Labels
patch Increment the patch version when merged released This issue/pull request has been released.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

iOS scrolling blocked
2 participants
@joshuascan @Ethella