Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

code: Fix warnings #212

Merged
merged 9 commits into from
Feb 25, 2024
Merged

code: Fix warnings #212

merged 9 commits into from
Feb 25, 2024

Conversation

felinira
Copy link
Collaborator

@felinira felinira commented Dec 9, 2023

No description provided.

src/transfer/v1.rs Show resolved Hide resolved
src/transit.rs Show resolved Hide resolved
src/transit.rs Show resolved Hide resolved
Copy link

codecov bot commented Dec 9, 2023

Codecov Report

Attention: Patch coverage is 41.66667% with 35 lines in your changes are missing coverage. Please review.

Project coverage is 40.34%. Comparing base (6b11a4c) to head (0f95f5d).
Report is 2 commits behind head on master.

Files Patch % Lines
src/transfer/v2.rs 0.00% 10 Missing ⚠️
cli/src/main.rs 0.00% 8 Missing ⚠️
src/transfer.rs 20.00% 4 Missing ⚠️
src/transfer/v1.rs 0.00% 4 Missing ⚠️
src/transit/crypto.rs 0.00% 4 Missing ⚠️
src/forwarding.rs 0.00% 2 Missing ⚠️
cli/src/util.rs 0.00% 1 Missing ⚠️
src/core.rs 88.88% 1 Missing ⚠️
src/transit.rs 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #212      +/-   ##
==========================================
+ Coverage   40.05%   40.34%   +0.29%     
==========================================
  Files          23       23              
  Lines        3298     3294       -4     
==========================================
+ Hits         1321     1329       +8     
+ Misses       1977     1965      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@felinira
Copy link
Collaborator Author

felinira commented Dec 9, 2023

I'm really confused by the CI failures, it builds fine for me with (presumably?) the same options and the same targets?

@felinira felinira force-pushed the fix-clippy branch 3 times, most recently from 9756358 to c0101d0 Compare December 9, 2023 21:19
@felinira
Copy link
Collaborator Author

I'm really confused by the CI failures, it builds fine for me with (presumably?) the same options and the same targets?

Answer to myself from myself from the future: This had apparently bumped the MSRV to 1.74. I would consider this to be something we might want to be doing anyway so I just bumped it to 1.75, for all the async improvements that landed in 1.75.

@felinira felinira merged commit 94cb80a into master Feb 25, 2024
14 checks passed
@felinira felinira deleted the fix-clippy branch February 25, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants