Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add magento/module-admin-analytics dependency #322

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

norgeindian
Copy link

This PR adds a needed dependency

Description (*)

The action group AdminLoginActionGroup adds the step fillOtp before clickDontAllowButtonIfVisible. The last step is introduced by Magento_AdminAnalytics and running MFTF tests will fail, if this step is not existent.

Fixed Issues (if relevant)

Manual testing scenarios (*)

  1. Remove Module Magento_AdminAnalytics from your codebase
  2. Run vendor/bin/mftf

Questions or comments

Contribution checklist (*)

  • [x ] Author has signed the Adobe CLA
  • [ x] Pull request has a meaningful description of its purpose
  • [ x] All commits are accompanied by meaningful commit messages
  • [ x] All new or changed code is covered with unit/integration tests (if applicable)
  • [ x] All automated tests passed successfully (all builds are green)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants