Fix address validation logic in shipping rate validator

[blmage]

Description (*)

The address validation logic in the shipping rate validator is broken: it incorrectly passes if any rule succeeds, rather than requiring that all necessary conditions be met. This can cause significant checkout problems under certain circumstances.

Fixed Issues (if relevant)

1. Fixes Registered shipping rates validators are not running #39039

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @blmage. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

---

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

[blmage]

@magento run all tests

[engcom-Hotel]

Hello @blmage,

Thanks for the contribution!

As we can see, this PR is fix of this issue #39039, please refer our comment here #39039 (comment) related to unable to reproduce the issue. Please help us with the same. Meanwhile we are moving this PR On Hold.

Thanks

[blmage]

@engcom-Hotel

Unfortunately, the issue is quite difficult to reproduce, as triggering it depends on various factors and would at least require installing a third-party module. However, since the logic is clearly flawed and the changeset consists of just one line, I suggest addressing the issue regardless.