Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

39395 telephone validation #39688

Open
wants to merge 5 commits into
base: 2.4-develop
Choose a base branch
from

Conversation

ajay2108
Copy link

@ajay2108 ajay2108 commented Feb 28, 2025

Description (*)

The issue was related to incorrect telephone validation in the customer address form. Previously, the validation was either missing or insufficient, allowing invalid telephone numbers to be entered. This could lead to issues in form submission and inconsistent data storage.

In this regard, my pull request proposes to enhance telephone validation by ensuring that only valid phone numbers are accepted in the customer address form, improving data integrity and user experience.

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes Telephone field in customer account does not validate #39395

Manual testing scenarios (*)

  1. Go to My Account as a logged-in customer.
  2. Attempt to Add or Edit the telephone field under account details.
  3. Enter invalid input, such as text or symbols (e.g., "abc123" or "!@#").
  4. Save the changes.

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

Copy link

m2-assistant bot commented Feb 28, 2025

Hi @ajay2108. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.


For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@ajay2108
Copy link
Author

@magento run all tests

1 similar comment
@ajay2108
Copy link
Author

ajay2108 commented Mar 3, 2025

@magento run all tests

@engcom-Hotel engcom-Hotel added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Mar 4, 2025
@ajay2108
Copy link
Author

ajay2108 commented Mar 5, 2025

@magento run Unit Tests

@ajay2108
Copy link
Author

ajay2108 commented Mar 6, 2025

@magento run all tests

@ajay2108
Copy link
Author

ajay2108 commented Mar 6, 2025

@magento run all tests

@ajay2108
Copy link
Author

ajay2108 commented Mar 7, 2025

@magento run Static Tests

@ajay2108
Copy link
Author

ajay2108 commented Mar 7, 2025

@magento run all tests

@ajay2108
Copy link
Author

@engcom-Hotel - Please verify above PR. It is showing failure of some automatic checks which are not related to my commit. Can you please have a look and let me know if anything is required from my end.

@ajay2108
Copy link
Author

@magento run Functional Tests B2B

@engcom-Hotel
Copy link
Contributor

@magento run Functional Tests EE, Functional Tests B2B, Unit Tests

@engcom-Hotel
Copy link
Contributor

Hello @ajay2108,

First of all, thank you for your contribution!

After reviewing the failed tests, I agree that they don't seem to be related to your changes. They might be flaky. However, we will thoroughly check the failed tests when we pick this PR for further processing.

Thank you

@ajay2108
Copy link
Author

@engcom-Hotel Thank you for your time and review!
I truly appreciate you sparing some time to provide feedback. Please feel free to review the PR at your convenience and do let me know if something is required from my side.

@ajay2108
Copy link
Author

@engcom-Hotel - Did you get chance to review this PR? It will be great if you can share your thoughts.

@engcom-Hotel
Copy link
Contributor

Hello @ajay2108,

Currently, we are working on the community-voted PRs listed on this board. We will address this PR according to our process. Your patience is appreciated.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: pending review
Projects
Status: Pending Review
Development

Successfully merging this pull request may close these issues.

Telephone field in customer account does not validate
2 participants