-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
39395 telephone validation #39688
base: 2.4-develop
Are you sure you want to change the base?
39395 telephone validation #39688
Conversation
Hi @ajay2108. Thank you for your contribution!
Allowed build names are:
You can find more information about the builds here For more details, review the Code Contributions documentation. |
@magento run all tests |
1 similar comment
@magento run all tests |
@magento run Unit Tests |
@magento run all tests |
@magento run all tests |
@magento run Static Tests |
@magento run all tests |
@engcom-Hotel - Please verify above PR. It is showing failure of some automatic checks which are not related to my commit. Can you please have a look and let me know if anything is required from my end. |
@magento run Functional Tests B2B |
@magento run Functional Tests EE, Functional Tests B2B, Unit Tests |
Hello @ajay2108, First of all, thank you for your contribution! After reviewing the failed tests, I agree that they don't seem to be related to your changes. They might be flaky. However, we will thoroughly check the failed tests when we pick this PR for further processing. Thank you |
@engcom-Hotel Thank you for your time and review! |
@engcom-Hotel - Did you get chance to review this PR? It will be great if you can share your thoughts. |
Hello @ajay2108, Currently, we are working on the community-voted PRs listed on this board. We will address this PR according to our process. Your patience is appreciated. Thanks |
Description (*)
The issue was related to incorrect telephone validation in the customer address form. Previously, the validation was either missing or insufficient, allowing invalid telephone numbers to be entered. This could lead to issues in form submission and inconsistent data storage.
In this regard, my pull request proposes to enhance telephone validation by ensuring that only valid phone numbers are accepted in the customer address form, improving data integrity and user experience.
Related Pull Requests
Fixed Issues (if relevant)
Manual testing scenarios (*)
Questions or comments
Contribution checklist (*)