Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow installing latest coding standard on Magento 2.4.5 #473

Conversation

ihor-sviziev
Copy link
Collaborator

@ihor-sviziev ihor-sviziev commented Nov 23, 2023

This pull request allows installing the latest version of coding standards to Magento 2.4.5-p5.
Currently it fails due to incompatibility with version of the webonyx/graphql-php package:

$ composer why-not magento/magento-coding-standard 32
magento/magento-coding-standard   32       requires         webonyx/graphql-php (^15.0)
magento/project-community-edition 2.4.5-p5 does not require webonyx/graphql-php (but v14.11.10 is installed)
magento/magento-coding-standard   32       requires         rector/rector (0.17.12)
magento/project-community-edition 2.4.5-p5 does not require rector/rector (but 0.14.8 is installed)
Not finding what you were looking for? Try calling `composer update "magento/magento-coding-standard:32" --dry-run` to get another view on the problem.
$ composer update "magento/magento-coding-standard:32" --dry-run -W
Loading composer repositories with package information
In Laminas\DependencyPlugin\DependencyRewriterV2::onPrePoolCreate
Updating dependencies
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - Root composer.json requires magento/magento-coding-standard * -> satisfiable by magento/magento-coding-standard[32].
    - magento/magento-coding-standard 32 requires webonyx/graphql-php ^15.0 -> found webonyx/graphql-php[v15.0.0, ..., v15.8.0] but these were not loaded, likely because it conflicts with another require.

Magento 2.4.5-p5 requires version webonyx/graphql-php:~14.11.5, while coding standard currently requires ^15.0

$ composer why webonyx/graphql-php
magento/framework                 103.0.5-p5 requires webonyx/graphql-php (~14.11.6)
magento/magento-coding-standard   29         requires webonyx/graphql-php (^14.9)
magento/module-graph-ql           100.4.5    requires webonyx/graphql-php (~14.11.5)
magento/product-community-edition 2.4.5-p5   requires webonyx/graphql-php (~14.11.6)

This version upgrade was added in 2466e63#diff-d2ab9925cad7eac58e0ff4cc0d251a937ecf49e4b6bf57f8b95aab76648a9d34R12.

Since it doesn't contain any other updates than a composer, I would suggest allowing both versions, and make compatible with older and newer Magento versions.

@ihor-sviziev
Copy link
Collaborator Author

Since EOL of magento 2.4.5 is less than in 1 year, I think it's not worth adding support for it anymore. closing this task.

@ihor-sviziev ihor-sviziev deleted the allow-installing-on-magento-2.4.5 branch September 11, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Ready for Review
Development

Successfully merging this pull request may close these issues.

1 participant