PHP 7.4 compatibility fix using implode() #81
Conversation
|
@magento run all tests |
|
Hi @amarroni, |
|
@NadiyaS the branch with code successfully imported into |
|
@magento import pr to magento-commerce/magento-cloud-patches |
|
@NadiyaS the pull request successfully imported. |
|
@BarnyShergold hi, after importing your PR into our private repo we did squash merge by mistake instead of regular merge, and now the author of the changes is |
|
@oshmyheliuk - I didn't make the PR on this, I just reviewed it 😄 |
|
I was!
It’s fine for my. If revert and create a new one is a big deal, don’t
worry.
If you want to make the revert I’ll glad. If not I fine too ha!
On Thu, 10 Dec 2020 at 06:53 Barny Shergold ***@***.***> wrote:
@oshmyheliuk <https://github.com/oshmyheliuk> - I didn't make the PR on
this, I just reviewed it 😄
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#81 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABHVFPZKXMX6RBOD7HNR6J3SUCLBRANCNFSM4UCXPQ6Q>
.
--
*Alejandro Marroni*
Magento Team Leader
<http://www.onetree.com/>
*Uruguay:*
18 de Julio 1077 Piso 10
CP 11100
Montevideo, Uruguay
Ph: (598) 2 908 4138
*www.onetree.com* <http://www.onetree.com/>
*USA:*
5400 Carillon Point
Building 5000, 4th Floor
Kirkland, Washington 98033
Ph: (425) 216 3710*Skype:* alejandro.marroni_ot
|
m2-community-project
bot
added
Progress: done
and removed
Progress: ready for review
labels
|
@amarroni we reverted PR and merged again without squash on this time |
MCLOUD-10736: Revert MCLOUD-10604 patch
After expected a issue with a deploy to environment we find out a compatibility problem.